From 3b5eb72ddf5e9e9aba61754a515463f345a70a36 Mon Sep 17 00:00:00 2001 From: Arthur BOUDREAULT <boudreaultarthur@ik.me> Date: Tue, 12 Oct 2021 15:33:02 +0200 Subject: [PATCH] =?UTF-8?q?=E2=99=BBRefactor:=20Ansible-lint:=20```=20Incl?= =?UTF-8?q?ude=20has=20some=20unintuitive=20behaviours=20depending=20on=20?= =?UTF-8?q?if=20it=20is=20running=20in=20a=20static=20or=20dynamic=20in=20?= =?UTF-8?q?play=20or=20in=20playbook=20context,=20in=20an=20effort=20to=20?= =?UTF-8?q?clarify=20behaviours=20we=20are=20moving=20to=20a=20new=20set?= =?UTF-8?q?=20modules=20(ansible.builtin.include=5Ftasks,=20ansible.builti?= =?UTF-8?q?n.include=5Frole,=20ansible.builtin.import=5Fplaybook,=20ansibl?= =?UTF-8?q?e.builtin.import=5Ftasks)=20that=20have=20well=20established=20?= =?UTF-8?q?and=20clear=20behaviours.=20This=20module=20will=20still=20be?= =?UTF-8?q?=20supported=20for=20some=20time=20but=20we=20are=20looking=20a?= =?UTF-8?q?t=20deprecating=20it=20in=20the=20near=20future.=20```?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix: I have decided to go for ansible include_tasks module because it is more versatile and on a par with this module (for more info about differences between new modules, see [here](https://docs.ansible.com/ansible/latest/collections/ansible/builtin/include_module.html) --- tasks/main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tasks/main.yml b/tasks/main.yml index 3d9e9ba..512acc7 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -30,7 +30,7 @@ when: ynh_file_install.stat.exists == False - name: Create extra domains - ansible.builtin.include: domains.yml + ansible.builtin.include_tasks: domains.yml when: ynh_extra_domains - name: Run first Yunohost diagnosis @@ -41,9 +41,9 @@ changed_when: False - name: Add Yunohost users - ansible.builtin.include: users.yml + ansible.builtin.include_tasks: users.yml when: ynh_users - name: Install Yunohost apps - ansible.builtin.include: apps.yml + ansible.builtin.include_tasks: apps.yml when: ynh_apps -- GitLab