Pour tout problème contactez-nous par mail : support@froggit.fr | La FAQ :grey_question: | Rejoignez-nous sur le Chat :speech_balloon:

Skip to content
Snippets Groups Projects
Karine Bauch's avatar
opened merge request !3 "Update to support python 3.9 to 3.13" at SWEPY / Fake Session Maker
Karine Bauch's avatar
commented on commit 3b382164 "tests: Tests passed with python>=3.9" at SWEPY / Fake Session Maker
Karine Bauch's avatar
commented on commit 36c50531 "test: fix fixture using fsm instead of fsm_factory in test_session_maker_factory" at SWEPY / Fake Session Maker
Karine Bauch's avatar
commented on commit 36c50531 "test: fix fixture using fsm instead of fsm_factory in test_session_maker_factory" at SWEPY / Fake Session Maker

I added fsm_factory because I need to access it for tests....

Karine Bauch's avatar
commented on commit c9bc21eb "pyproject.toml updated with uv --dev" at SWEPY / Fake Session Maker

I don’t know, that’s why I kept it....

Karine Bauch's avatar
commented on commit 36c50531 "test: fix fixture using fsm instead of fsm_factory in test_session_maker_factory" at SWEPY / Fake Session Maker

OK, I’ll pay attention from now on

Dorian Turba's avatar
commented on commit 36c50531 "test: fix fixture using fsm instead of fsm_factory in test_session_maker_factory" at SWEPY / Fake Session Maker

@Karine-Bauch Next time, commits those documentation into a dedicated chore: doc ... commit, it hides away the important changes you made.

Karine Bauch's avatar
commented on commit 36c50531 "test: fix fixture using fsm instead of fsm_factory in test_session_maker_factory" at SWEPY / Fake Session Maker

I haven’t fixed all mypy warnings....

Dorian Turba's avatar
commented on commit 36c50531 "test: fix fixture using fsm instead of fsm_factory in test_session_maker_factory" at SWEPY / Fake Session Maker

@Karine-Bauch we should consider add async_fsm_factory to the public API, don't you think?

Dorian Turba's avatar
commented on commit 36c50531 "test: fix fixture using fsm instead of fsm_factory in test_session_maker_factory" at SWEPY / Fake Session Maker

@Karine-Bauch why a . here, and not in the other docstrings?

Karine Bauch's avatar
commented on commit 3b382164 "tests: Tests passed with python>=3.9" at SWEPY / Fake Session Maker

I have added it before realizing that we don’t need python 3.7 and 3.8...

Dorian Turba's avatar
commented on commit c9bc21eb "pyproject.toml updated with uv --dev" at SWEPY / Fake Session Maker
Dorian Turba's avatar
commented on commit 36c50531 "test: fix fixture using fsm instead of fsm_factory in test_session_maker_factory" at SWEPY / Fake Session Maker
Dorian Turba's avatar
commented on commit 3b382164 "tests: Tests passed with python>=3.9" at SWEPY / Fake Session Maker
Dorian Turba's avatar
commented on commit 3b382164 "tests: Tests passed with python>=3.9" at SWEPY / Fake Session Maker

Binary is a very bad thing for sec. Stick with psycopg2 and fix to binary for dev env OR only for dev distributions that needs it (even better).

Dorian Turba's avatar
commented on commit c9bc21eb "pyproject.toml updated with uv --dev" at SWEPY / Fake Session Maker

Do we still needs pip-tools anymore?

Dorian Turba's avatar
commented on commit c9bc21eb "pyproject.toml updated with uv --dev" at SWEPY / Fake Session Maker

Yep, good.

Dorian Turba's avatar
commented on commit 36c50531 "test: fix fixture using fsm instead of fsm_factory in test_session_maker_factory" at SWEPY / Fake Session Maker

Oh, I forgot that... Well done

Karine Bauch's avatar
pushed to branch trunk at SWEPY / Fake Session Maker
  • 3b382164 · tests: Tests passed with python>=3.9
Karine Bauch's avatar
pushed to branch trunk at SWEPY / Fake Session Maker
  • c9bc21eb · pyproject.toml updated with uv --dev