Arthur BOUDREAULT authored 3 years ago and Christophe Chaudier committed 3 years ago

- fix: [201] Trailing whitespace REMOVED
- fix: meta-no-tags: Use 'galaxy_tags' rather than 'categories' REPLACED + role in Debian 10 only
- fix: [601] Don't compare to literal True/False FIXED

Arthur BOUDREAULT authored 3 years ago and Christophe Chaudier committed 3 years ago

Ansible-lint:
```
Include has some unintuitive behaviours depending on if it is running in a static or dynamic in play or in playbook context, in an effort to clarify behaviours we are moving to a new set modules (ansible.builtin.include_tasks, ansible.builtin.include_role, ansible.builtin.import_playbook, ansible.builtin.import_tasks) that have well established and clear behaviours.
This module will still be supported for some time but we are looking at deprecating it in the near future.
```

Fix: I have decided to go for ansible include_tasks module because it is more versatile and on a par with this module (for more info about differences between new modules, see [here](https://docs.ansible.com/ansible/latest/collections/ansible/builtin/include_module.html)

Arthur BOUDREAULT authored 3 years ago and Christophe Chaudier committed 3 years ago

Shell module is not needed here.

According to various sources (https://www.youtube.com/watch?v=57gAqKvAKck or https://stackoverflow.com/questions/56663332/difference-between-shell-and-command-in-ansible) it is not useful to use shell ansible module when not working with operands. Therefore I have decided to switch every actions to command module, more secure. Ansible-lint says "Shell should only be used when piping, redirecting or chaining commands"

Arthur BOUDREAULT authored 3 years ago and Christophe Chaudier committed 3 years ago

refactor: changed variables pattern to be more consistent with ansible good practises and more flexible to use.
refactor: remove useless comment
doc: Readme in English and French

Arthur BOUDREAULT authored 3 years ago and Christophe Chaudier committed 3 years ago

This feature is system-related, not yunohost-related