Resolve "fix: ci lint"

added Doing label

Thanks to @thomas_michel suggestions, I'm going to change the way Ansible tests are done.

Some issues have been declared by Ansible-lint:

literal-compare: Don't compare to literal True/False -> FROM : when: ynh_file_install.stat.exists == False to when: not ynh_file_install.stat.exists TESTS OK
no-changed-when: Commands should not change things if nothing needs doing -> YNH Diagnosis should be run after initial installation but then it shouldn't need to run at every execution of the playbook (more info here ) ADDED a check : Run the command if ynh isn't installed yet (first role run), otherwise skip this action (following role runs).

name: Run first Yunohost diagnosis
  ansible.builtin.command: yunohost diagnosis run
  when: not ynh_file_install.stat.exists

changed title from Draft: Resolve "Ansible test: when...is smth rather than == smth" to Draft: Resolve "fix: ci lint"

added 12 commits

669d3ebb...abe8ccb9 - 9 commits from branch master
fcf734b1 - fix: [201] Trailing whitespace REMOVED
6afdb77b - fix: [601] Don't compare to literal True/False FIXED
1bf97177 - fix: meta-no-tags: Use 'galaxy_tags' rather than 'categories' REPLACED + role in Debian 10 only

added 2 commits

1243031f - fix: meta-no-tags: Use 'galaxy_tags' rather than 'categories' REPLACED + role in Debian 10 only
f5364d61 - fix: [601] Don't compare to literal True/False FIXED

I have remade the previous commits because the first ones were not complete. Ansible lint passed!

changed title from Draft: Resolve "fix: ci lint" to Draft: Resolve "fix: ci lint"

added Need review label and removed Doing label

marked this merge request as ready

approved this merge request

marked this merge request as draft

added Doing label and removed Need review label

resolved all threads

added 1 commit

marked this merge request as ready

approved this merge request

Merge request reports